Change mapRectScaleTranslate to pass args/ret by value

Change mapRectScaleTranslate to pass args/ret by value

This reverts commit 6092b6e0e57be20d2e1ad079c0af133d2f67bfd3.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138943002

Committed: https://skia.googlesource.com/skia/+/1bd13ca922d6448d595064faee486eaf3fa56e56

[reed1, 2016-07-11 18:25:29]

Description was changed from

==========
Change mapRectScaleTranslate to pass args/ret by value

This reverts commit 6092b6e0e57be20d2e1ad079c0af133d2f67bfd3.

BUG=skia:
==========

to

==========
Change mapRectScaleTranslate to pass args/ret by value

This reverts commit 6092b6e0e57be20d2e1ad079c0af133d2f67bfd3.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138943002
==========

[reed1, 2016-07-11 19:23:26]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 19:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-11 19:23:51]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-07-11 19:25:02]

reed@google.com changed reviewers:
+ mtklein@google.com

[reed1, 2016-07-11 19:25:03]

trying again, after NDK upgrade

[mtklein, 2016-07-11 19:31:24]

lgtm

I take it one of the trybots is the previously failing bot?

[reed1, 2016-07-11 19:33:53]

On 2016/07/11 19:31:24, mtklein wrote:
> lgtm
> 
> I take it one of the trybots is the previously failing bot?

I think so. The Perf-Android bot

[reed1, 2016-07-11 19:56:01]

no joy on GCC

[mtklein, 2016-07-11 20:37:50]

On 2016/07/11 19:56:01, reed1 wrote:
> no joy on GCC

That is disappointing.  We could try Clang, but I think this particular bot is
most similar to Clank's release build.

[reed1, 2016-07-11 20:40:11]

I guess I could conditionally make the change just for clang (for now), and just
mock the API for GCC (until we can avoid the bug)...

[mtklein, 2016-07-11 21:20:20]

On 2016/07/11 20:40:11, reed1 wrote:
> I guess I could conditionally make the change just for clang (for now), and
just
> mock the API for GCC (until we can avoid the bug)...

This both disgusts me and sounds good to me.  If we think Android's on Clang
now, we might as well do this guarded by defined(__clang__) to see if we get a
benefit there.  If we do, it's another carrot on the bushel to motivate Clank's
transition to Clang too.

For what it's worth, MSVC seems fine here too, so the guard is probably best as
!defined(__GNUC__) || defined(__clang__).

[reed1, 2016-08-10 02:07:59]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 02:08:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 02:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 02:26:19]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-08-10 13:16:46]

reed@google.com changed reviewers:
+ msarett@google.com

[reed1, 2016-08-10 13:16:52]

The CQ bit was checked by reed@google.com

[reed1, 2016-08-10 13:16:52]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2138943002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-10 13:16:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 13:17:58]

Description was changed from

==========
Change mapRectScaleTranslate to pass args/ret by value

This reverts commit 6092b6e0e57be20d2e1ad079c0af133d2f67bfd3.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138943002
==========

to

==========
Change mapRectScaleTranslate to pass args/ret by value

This reverts commit 6092b6e0e57be20d2e1ad079c0af133d2f67bfd3.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138943002

Committed:
https://skia.googlesource.com/skia/+/1bd13ca922d6448d595064faee486eaf3fa56e56
==========

[commit-bot: I haz the power, 2016-08-10 13:17:59]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1bd13ca922d6448d595064faee486eaf3fa56e56

[hal.canary, 2016-08-10 14:13:10]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2234843002/ by halcanary@google.com.

The reason for reverting is: Build-Ubuntu-GCC-Arm7-Release-Android fails..