Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2138813002: Revert of Do not wait for first video frame to start playing audio in a MediaStream. (patchset #2 i… (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of Do not wait for first video frame to start playing audio in a MediaStream. (patchset #2 id:20001 of https://codereview.chromium.org/2108153002/ ) Reason for revert: According to the spec, we should switch state to HAVE_METADATA only after we know the dimensions of the video. See crbug.com/625943 Original issue's description: > Do not wait for first video frame to start playing audio in a MediaStream. > > BUG=403710 > > Committed: https://crrev.com/7161bf0bd58551daac1aa486ca9bb13376efbbec > Cr-Commit-Position: refs/heads/master@{#402845} TBR=tommi@chromium.org BUG=403710, 625943 Review-Url: https://codereview.chromium.org/2124013003 Cr-Commit-Position: refs/heads/master@{#404138} (cherry picked from commit 20dbd3b5467a741c7eafe1b1365b0d05361e6bc3) Committed: https://chromium.googlesource.com/chromium/src/+/f3131b3567fcf1600f7f6ebb44ac56e658ba1b55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/test/data/media/getusermedia.html View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
4 years, 5 months ago (2016-07-11 15:31:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3131b3567fcf1600f7f6ebb44ac56e658ba1b55.

Powered by Google App Engine
This is Rietveld 408576698