Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2124013003: Revert of Do not wait for first video frame to start playing audio in a MediaStream. (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not wait for first video frame to start playing audio in a MediaStream. (patchset #2 id:20001 of https://codereview.chromium.org/2108153002/ ) Reason for revert: According to the spec, we should switch state to HAVE_METADATA only after we know the dimensions of the video. See crbug.com/625943 Original issue's description: > Do not wait for first video frame to start playing audio in a MediaStream. > > BUG=403710 > > Committed: https://crrev.com/7161bf0bd58551daac1aa486ca9bb13376efbbec > Cr-Commit-Position: refs/heads/master@{#402845} TBR=tommi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=403710, 625943 Committed: https://crrev.com/20dbd3b5467a741c7eafe1b1365b0d05361e6bc3 Cr-Commit-Position: refs/heads/master@{#404138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/test/data/media/getusermedia.html View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Guido Urdaneta
Created Revert of Do not wait for first video frame to start playing audio in ...
4 years, 5 months ago (2016-07-07 11:24:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2124013003/1
4 years, 5 months ago (2016-07-07 11:24:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 12:36:09 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 12:36:11 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 12:37:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20dbd3b5467a741c7eafe1b1365b0d05361e6bc3
Cr-Commit-Position: refs/heads/master@{#404138}

Powered by Google App Engine
This is Rietveld 408576698