Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4415)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

Issue 2138643004: [Autofill] Add support for signin promo on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aaa
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java
index 34b66fcc4ec94666db7d9b6f0257f670ccfe2581..ce84d699db4aa3a39650bae88dd75f84a48a30e8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java
@@ -7,10 +7,12 @@ package org.chromium.chrome.browser.signin;
import android.app.Activity;
import android.text.TextUtils;
+import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.sync.signin.ChromeSigninController;
+import org.chromium.ui.base.WindowAndroid;
/**
* Helper functions for promoting sign in.
@@ -41,4 +43,18 @@ public class SigninPromoUtil {
preferenceManager.setSigninPromoShown();
return true;
}
+
+ /**
+ * A convenience method to create an AccountSigninActivity, passing the access point as an
+ * intent extra.
+ * @param window WindowAndroid from which to get the Activity/Context.
+ * @param accessPoint for metrics purposes.
+ */
+ @CalledByNative
+ private static void openAccountSigninActivityForPromo(WindowAndroid window, int accessPoint) {
+ Activity activity = window.getActivity().get();
+ if (activity != null) {
+ AccountSigninActivity.startIfAllowed(activity, accessPoint);
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698