Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3963)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

Issue 2138643004: [Autofill] Add support for signin promo on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aaa
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java
index 4717325e329ea0b2e7b52bcea9cd4b4f4c9b7243..6b152726f5c0bd58ca91e4528753eaa65753c2f7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java
@@ -41,7 +41,7 @@ public class AccountSigninActivity extends AppCompatActivity
@IntDef({SigninAccessPoint.SETTINGS, SigninAccessPoint.BOOKMARK_MANAGER,
SigninAccessPoint.RECENT_TABS, SigninAccessPoint.SIGNIN_PROMO,
- SigninAccessPoint.NTP_LINK})
+ SigninAccessPoint.NTP_LINK, SigninAccessPoint.AUTOFILL_DROPDOWN})
@Retention(RetentionPolicy.SOURCE)
public @interface AccessPoint {}
@AccessPoint private int mAccessPoint;
@@ -97,6 +97,7 @@ public class AccountSigninActivity extends AppCompatActivity
|| mAccessPoint == SigninAccessPoint.RECENT_TABS
|| mAccessPoint == SigninAccessPoint.SETTINGS
|| mAccessPoint == SigninAccessPoint.SIGNIN_PROMO
+ || mAccessPoint == SigninAccessPoint.AUTOFILL_DROPDOWN
: "invalid access point: " + mAccessPoint;
mView = (AccountSigninView) LayoutInflater.from(this).inflate(
@@ -173,6 +174,9 @@ public class AccountSigninActivity extends AppCompatActivity
private void recordSigninStartedUserAction() {
switch (getAccessPoint()) {
+ case SigninAccessPoint.AUTOFILL_DROPDOWN:
+ RecordUserAction.record("Signin_Signin_FromAutofillDropdown");
+ break;
case SigninAccessPoint.BOOKMARK_MANAGER:
RecordUserAction.record("Signin_Signin_FromBookmarkManager");
break;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698