Issue 21384: Fix mini_installer failing on Windows 7 (issue 7732)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21384: Fix mini_installer failing on Windows 7 (issue 7732).... (Closed)

Created:
11 years, 10 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
kuchhal, Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix mini_installer failing on Windows 7 (issue 7732). In r9694, nsylvain changed win_util::GetWinVersion to return more specific values for Windows 6.0 and later. InstallUtil::IsOSSupported() needs to handle these new enums. BUG=7732 R= kuchhal TEST= None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9858

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/installer/util/install_util.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Larson

See http://codereview.chromium.org/21274 for the change nsylvain made to win_util::GetWinVersion().

11 years, 10 months ago (2009-02-15 03:11:54 UTC) #1

LGTM, thanks

Expand Messages | Collapse Messages