Issue 21274: Add code to be able to detect windows7 in GetWinVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21274: Add code to be able to detect windows7 in GetWinVersion. (Closed)

Created:
11 years, 10 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add code to be able to detect windows7 and 2008 in GetWinVersion. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9694

Patch Set 8 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	base/win_util.h	View	1 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	base/win_util.cc	View	1 2 3 4 5 6 7	2 chunks	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

http://codereview.chromium.org/21274/diff/1003/1004 File base/win_util.cc (right): http://codereview.chromium.org/21274/diff/1003/1004#newcode69 Line 69: win_version = WINVERSION_WIN7; Maybe it is better to ...

11 years, 10 months ago (2009-02-12 00:46:29 UTC) #2

LGTM, Thanks.

Expand Messages | Collapse Messages

Issue 21274: Add code to be able to detect windows7 in GetWinVersion. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Messages