ui/views/corewm/tooltip_controller_test_helper.cc - Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/corewm/tooltip_controller_test_helper.cc

Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Write unit test for the case when a tooltip moves from one view to another with the same tooltip bu… Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/corewm/tooltip.h ('K') | « ui/views/corewm/tooltip_controller_test_helper.h ('k') | ui/views/corewm/tooltip_controller_unittest.cc » ('j') | ui/views/widget/tooltip_manager_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/corewm/tooltip_controller_test_helper.cc

diff --git a/ui/views/corewm/tooltip_controller_test_helper.cc b/ui/views/corewm/tooltip_controller_test_helper.cc

index f96b08dc50a425ee416a2ea60704ed1b170096d1..1f02c315cde5c7279543f2bcb0742f612534edea 100644

--- a/ui/views/corewm/tooltip_controller_test_helper.cc

+++ b/ui/views/corewm/tooltip_controller_test_helper.cc

@@ -5,6 +5,7 @@

#include "ui/views/corewm/tooltip_controller_test_helper.h"

#include "ui/aura/window.h"

+#include "ui/views/corewm/tooltip.h"

#include "ui/views/corewm/tooltip_controller.h"

namespace views {

@@ -19,6 +20,12 @@ TooltipControllerTestHelper::TooltipControllerTestHelper(

TooltipControllerTestHelper::~TooltipControllerTestHelper() {

}

+gfx::Point TooltipControllerTestHelper::GetTooltipPosition() {

+ if (!controller_->tooltip_)

+ return gfx::Point();

+ return controller_->tooltip_->GetTooltipPosition();

base::string16 TooltipControllerTestHelper::GetTooltipText() {

return controller_->tooltip_text_;

}