Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: ui/views/corewm/tooltip.h

Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Write unit test for the case when a tooltip moves from one view to another with the same tooltip bu… Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/corewm/tooltip.h
diff --git a/ui/views/corewm/tooltip.h b/ui/views/corewm/tooltip.h
index 7fb15bc32ca3cb7e53517a95709342b609b0e30a..1971f6e19e3ab727f27f308b9935abdb0a9e20e9 100644
--- a/ui/views/corewm/tooltip.h
+++ b/ui/views/corewm/tooltip.h
@@ -16,6 +16,10 @@ namespace gfx {
class Point;
}
+namespace test {
+ class TooltipControllerTestHelper;
+} // namespace test
+
namespace views {
namespace corewm {
@@ -38,6 +42,11 @@ class VIEWS_EXPORT Tooltip {
// Is the tooltip visibile?
virtual bool IsVisible() = 0;
+
+ private:
+ friend class test::TooltipControllerTestHelper;
+
+ virtual gfx::Point GetTooltipPosition() = 0;
sky 2014/04/10 16:12:08 You shouldn't have to expose this to test the fix.
};
} // namespace corewm

Powered by Google App Engine
This is Rietveld 408576698