Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: ui/views/corewm/tooltip_controller.h

Issue 213833018: Aura tooltips do not move on mouse move in case of many neighboring views with the same label (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Write unit test for the case when a tooltip moves from one view to another with the same tooltip bu… Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/corewm/tooltip_controller.h
diff --git a/ui/views/corewm/tooltip_controller.h b/ui/views/corewm/tooltip_controller.h
index 9815df1817a46d4f76cf17c459310b0502a34ead..0dff66b14b382b0ed87c32ed4673dfd9acff6e1d 100644
--- a/ui/views/corewm/tooltip_controller.h
+++ b/ui/views/corewm/tooltip_controller.h
@@ -38,7 +38,8 @@ class VIEWS_EXPORT TooltipController : public aura::client::TooltipClient,
virtual ~TooltipController();
// Overridden from aura::client::TooltipClient.
- virtual void UpdateTooltip(aura::Window* target) OVERRIDE;
+ virtual void UpdateTooltip(aura::Window* target,
+ bool force) OVERRIDE;
virtual void SetTooltipShownTimeout(aura::Window* target,
int timeout_in_ms) OVERRIDE;
virtual void SetTooltipsEnabled(bool enable) OVERRIDE;
@@ -61,8 +62,9 @@ class VIEWS_EXPORT TooltipController : public aura::client::TooltipClient,
void TooltipShownTimerFired();
// Updates the tooltip if required (if there is any change in the tooltip
- // text or the aura::Window.
- void UpdateIfRequired();
+ // text or the aura::Window). If |force| is true the tooltip will be updated
+ // regardless of these conditions.
+ void UpdateIfRequired(bool force);
// Only used in tests.
bool IsTooltipVisible();

Powered by Google App Engine
This is Rietveld 408576698