Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 213833016: DevTools: Fix batch updates dropping methods invocations. (Closed)

Created:
6 years, 8 months ago by alph
Modified:
6 years, 8 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Fix batch updates dropping methods invocations. Do not skip method invocations inside requestAnimationFrame when it has entered a new batch sequence. Otherwise the scheduled method invocations get lost. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M Source/devtools/front_end/UIUtils.js View 9 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
ptal
6 years, 8 months ago (2014-04-01 12:19:22 UTC) #1
yurys
lgtm
6 years, 8 months ago (2014-04-01 12:33:52 UTC) #2
alph
The CQ bit was checked by alph@chromium.org
6 years, 8 months ago (2014-04-01 12:53:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/213833016/1
6 years, 8 months ago (2014-04-01 12:53:05 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 14:03:11 UTC) #5
Message was sent while issue was closed.
Change committed as 170566

Powered by Google App Engine
This is Rietveld 408576698