Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: Source/devtools/front_end/UIUtils.js

Issue 213833016: DevTools: Fix batch updates dropping methods invocations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/UIUtils.js
diff --git a/Source/devtools/front_end/UIUtils.js b/Source/devtools/front_end/UIUtils.js
index e8d7b02fc2da2d18c8244e2a9c8d710ff7e3a7ea..e1a22692ef5ac9a66b2fa7a25268aa1de6e73662 100644
--- a/Source/devtools/front_end/UIUtils.js
+++ b/Source/devtools/front_end/UIUtils.js
@@ -219,7 +219,7 @@ WebInspector._valueModificationDirection = function(event)
if (event.keyIdentifier === "Up" || event.keyIdentifier === "PageUp")
direction = "Up";
else if (event.keyIdentifier === "Down" || event.keyIdentifier === "PageDown")
- direction = "Down";
+ direction = "Down";
}
return direction;
}
@@ -272,7 +272,7 @@ WebInspector._modifiedFloatNumber = function(number, event)
var direction = WebInspector._valueModificationDirection(event);
if (!direction)
return number;
-
+
var arrowKeyOrMouseWheelEvent = (event.keyIdentifier === "Up" || event.keyIdentifier === "Down" || event.type === "mousewheel");
// Jump by 10 when shift is down or jump by 0.1 when Alt/Option is down.
@@ -323,7 +323,7 @@ WebInspector.handleElementValueModifications = function(event, element, finishHa
var originalValue = element.textContent;
var wordRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, WebInspector.StyleValueDelimiters, element);
var wordString = wordRange.toString();
-
+
if (suggestionHandler && suggestionHandler(wordString))
return false;
@@ -336,7 +336,7 @@ WebInspector.handleElementValueModifications = function(event, element, finishHa
prefix = matches[1];
suffix = matches[3];
number = WebInspector._modifiedHexValue(matches[2], event);
-
+
if (customNumberHandler)
number = customNumberHandler(number);
@@ -347,11 +347,11 @@ WebInspector.handleElementValueModifications = function(event, element, finishHa
prefix = matches[1];
suffix = matches[3];
number = WebInspector._modifiedFloatNumber(parseFloat(matches[2]), event);
-
+
// Need to check for null explicitly.
- if (number === null)
+ if (number === null)
return false;
-
+
if (customNumberHandler)
number = customNumberHandler(number);
@@ -374,7 +374,7 @@ WebInspector.handleElementValueModifications = function(event, element, finishHa
event.handled = true;
event.preventDefault();
-
+
if (finishHandler)
finishHandler(originalValue, replacementString);
@@ -539,7 +539,7 @@ WebInspector._documentBlurred = function(event)
WebInspector.setCurrentFocusElement(null);
}
-WebInspector._textInputTypes = ["text", "search", "tel", "url", "email", "password"].keySet();
+WebInspector._textInputTypes = ["text", "search", "tel", "url", "email", "password"].keySet();
WebInspector._isTextEditingElement = function(element)
{
if (element instanceof HTMLInputElement)
@@ -791,12 +791,10 @@ WebInspector.endBatchUpdate = function()
delete WebInspector._postUpdateHandlers;
window.requestAnimationFrame(function() {
- if (WebInspector._coalescingLevel)
- return;
var keys = handlers.keys();
for (var i = 0; i < keys.length; ++i) {
var object = keys[i];
- var methods = handlers.get(object).keys();
+ var methods = handlers.get(object).items();
for (var j = 0; j < methods.length; ++j)
methods[j].call(object);
}
@@ -810,19 +808,16 @@ WebInspector.endBatchUpdate = function()
WebInspector.invokeOnceAfterBatchUpdate = function(object, method)
{
if (!WebInspector._coalescingLevel) {
- window.requestAnimationFrame(function() {
- if (!WebInspector._coalescingLevel)
- method.call(object);
- });
+ window.requestAnimationFrame(method.bind(object));
return;
}
var methods = WebInspector._postUpdateHandlers.get(object);
if (!methods) {
- methods = new Map();
+ methods = new Set();
WebInspector._postUpdateHandlers.put(object, methods);
}
- methods.put(method);
+ methods.add(method);
}
;(function() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698