Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 2138303002: Update timeline-set-current-time to test setting animation timelines instead of document timelines (Closed)

Created:
4 years, 5 months ago by meade_UTC10
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update timeline-set-current-time to test setting animation timelines instead of document timelines Unfortunately, we do not yet implement DocumentTimeline, so this test fails. Relevant spec: http://w3c.github.io/web-animations/#the-current-time-of-an-animation BUG=623437 Committed: https://crrev.com/ac70c4ee8550a97b745b94a581c66eb59b3a6251 Cr-Commit-Position: refs/heads/master@{#405016}

Patch Set 1 #

Patch Set 2 : update timeline-set-current-time-test and add expectation #

Patch Set 3 : Sync to head #

Patch Set 4 : Reparent branch #

Patch Set 5 : Revert irrelevant files #

Patch Set 6 : Make test use proper relative times, rename files #

Patch Set 7 : Add help link #

Patch Set 8 : Use assert_times_equal instead of assert_approx_equal #

Patch Set 9 : Rename file to .txt instead of .html (oops) #

Messages

Total messages: 20 (13 generated)
meade_UTC10
4 years, 5 months ago (2016-07-12 05:54:54 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 06:04:46 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2145473002 Patch 1). Please resolve the dependency and ...
4 years, 5 months ago (2016-07-12 06:13:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138303002/140001
4 years, 5 months ago (2016-07-13 01:19:41 UTC) #15
commit-bot: I haz the power
Committed patchset #9 (id:140001)
4 years, 5 months ago (2016-07-13 04:23:06 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 04:23:29 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:25:48 UTC) #20
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/ac70c4ee8550a97b745b94a581c66eb59b3a6251
Cr-Commit-Position: refs/heads/master@{#405016}

Powered by Google App Engine
This is Rietveld 408576698