Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2138263002: Revert of Move content's shell connections to the IO thread (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, enne (OOO), jam, piman+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move content's shell connections to the IO thread (patchset #14 id:320001 of https://codereview.chromium.org/2111353002/ ) Reason for revert: http://crbug.com/627277 Original issue's description: > Move content's service manager connections to the IO thread > > Moves all service manager connections in the content layer > (connections owned by instances of MojoShellConnection and > MojoChildConnection) to the IO thread in all process types. > Note that instances of MojoShellConnection and > MojoChildConnection may still be created and used on > any thread. > > Additionally exposes a way for InterfaceRegistry and > InterfaceProvider to forward to/from other instances > so we can still have a corresponding instance of each > on whatever thread owns the Mojo[Shell/Child]Connection > object. > > This simplifies interface registration and acquisition > on process hosts and ChildThreadImpls, and makes it possible > for a future CL to introduce IO-thread service registration > to avoid thread hops when binding incoming interface requests. > > BUG=623398, 612500 > > Committed: https://crrev.com/439768f0aaaea83ffb7ce6c3ba4438804582c383 > Committed: https://crrev.com/0771b1d71a3295691f9ffaefdf50652bd58e01c4 > Cr-Original-Commit-Position: refs/heads/master@{#404228} > Cr-Commit-Position: refs/heads/master@{#404556} TBR=ben@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623398, 612500 NOTRY=true Committed: https://crrev.com/d535a2c52c815ed792cba4ebbeb621816cd013b8 Cr-Commit-Position: refs/heads/master@{#404816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -1159 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.h View 1 chunk +46 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.cc View 3 chunks +39 lines, -98 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/browser_context.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.h View 3 chunks +5 lines, -26 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 2 chunks +27 lines, -148 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 4 chunks +23 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 6 chunks +16 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/child/background_sync/background_sync_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_thread_impl.h View 6 chunks +9 lines, -10 lines 0 comments Download
M content/child/child_thread_impl.cc View 8 chunks +17 lines, -24 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 chunk +33 lines, -38 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 2 chunks +137 lines, -385 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.h View 4 chunks +8 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 6 chunks +34 lines, -16 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/child/child_thread.h View 2 chunks +1 line, -3 lines 0 comments Download
D content/public/common/connection_filter.h View 1 chunk +0 lines, -40 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 4 chunks +12 lines, -43 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 4 chunks +11 lines, -27 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M services/navigation/BUILD.gn View 1 chunk +2 lines, -7 lines 0 comments Download
M services/navigation/content_client/content_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/navigation/navigation.h View 4 chunks +6 lines, -9 lines 0 comments Download
M services/navigation/navigation.cc View 2 chunks +10 lines, -29 lines 0 comments Download
M services/navigation/view_impl.h View 3 chunks +2 lines, -4 lines 0 comments Download
M services/navigation/view_impl.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M services/shell/public/cpp/connection.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/shell/public/cpp/connector.h View 1 chunk +0 lines, -4 lines 0 comments Download
M services/shell/public/cpp/interface_provider.h View 3 chunks +0 lines, -15 lines 0 comments Download
M services/shell/public/cpp/interface_registry.h View 4 chunks +0 lines, -19 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M services/shell/public/cpp/lib/connector_impl.cc View 4 chunks +20 lines, -42 lines 0 comments Download
M services/shell/public/cpp/lib/interface_provider.cc View 2 chunks +1 line, -21 lines 0 comments Download
M services/shell/public/cpp/lib/interface_registry.cc View 2 chunks +6 lines, -17 lines 0 comments Download
M services/shell/public/cpp/lib/service_context.cc View 5 chunks +44 lines, -25 lines 0 comments Download
M services/shell/public/cpp/service_context.h View 3 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Ken Rockot(use gerrit already)
Created Revert of Move content's shell connections to the IO thread
4 years, 5 months ago (2016-07-11 22:58:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138263002/1
4 years, 5 months ago (2016-07-11 22:59:37 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260469)
4 years, 5 months ago (2016-07-12 02:07:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138263002/1
4 years, 5 months ago (2016-07-12 05:12:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260790)
4 years, 5 months ago (2016-07-12 08:09:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138263002/1
4 years, 5 months ago (2016-07-12 13:22:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261044)
4 years, 5 months ago (2016-07-12 16:20:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138263002/1
4 years, 5 months ago (2016-07-12 17:48:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138263002/1
4 years, 5 months ago (2016-07-12 18:13:32 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 18:27:00 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 18:27:23 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 18:28:37 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d535a2c52c815ed792cba4ebbeb621816cd013b8
Cr-Commit-Position: refs/heads/master@{#404816}

Powered by Google App Engine
This is Rietveld 408576698