Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Side by Side Diff: services/shell/public/cpp/lib/interface_registry.cc

Issue 2138263002: Revert of Move content's shell connections to the IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/shell/public/cpp/interface_registry.h" 5 #include "services/shell/public/cpp/interface_registry.h"
6 6
7 #include "services/shell/public/cpp/connection.h" 7 #include "services/shell/public/cpp/connection.h"
8 8
9 namespace shell { 9 namespace shell {
10 10
(...skipping 21 matching lines...) Expand all
32 name); 32 name);
33 } 33 }
34 34
35 void InterfaceRegistry::RemoveInterface(const std::string& name) { 35 void InterfaceRegistry::RemoveInterface(const std::string& name) {
36 auto it = name_to_binder_.find(name); 36 auto it = name_to_binder_.find(name);
37 if (it != name_to_binder_.end()) 37 if (it != name_to_binder_.end())
38 name_to_binder_.erase(it); 38 name_to_binder_.erase(it);
39 } 39 }
40 40
41 void InterfaceRegistry::PauseBinding() { 41 void InterfaceRegistry::PauseBinding() {
42 DCHECK(!is_paused_); 42 DCHECK(!pending_request_.is_pending());
43 is_paused_ = true; 43 DCHECK(binding_.is_bound());
44 pending_request_ = binding_.Unbind();
44 } 45 }
45 46
46 void InterfaceRegistry::ResumeBinding() { 47 void InterfaceRegistry::ResumeBinding() {
47 DCHECK(is_paused_); 48 DCHECK(pending_request_.is_pending());
48 is_paused_ = false; 49 DCHECK(!binding_.is_bound());
49 50 binding_.Bind(std::move(pending_request_));
50 while (!pending_interface_requests_.empty()) {
51 auto& request = pending_interface_requests_.front();
52 GetInterface(request.first, std::move(request.second));
53 pending_interface_requests_.pop();
54 }
55 } 51 }
56 52
57 // mojom::InterfaceProvider: 53 // mojom::InterfaceProvider:
58 void InterfaceRegistry::GetInterface(const mojo::String& interface_name, 54 void InterfaceRegistry::GetInterface(const mojo::String& interface_name,
59 mojo::ScopedMessagePipeHandle handle) { 55 mojo::ScopedMessagePipeHandle handle) {
60 if (is_paused_) {
61 pending_interface_requests_.emplace(interface_name, std::move(handle));
62 return;
63 }
64
65 auto iter = name_to_binder_.find(interface_name); 56 auto iter = name_to_binder_.find(interface_name);
66 if (iter != name_to_binder_.end()) { 57 if (iter != name_to_binder_.end()) {
67 iter->second->BindInterface(connection_, interface_name, std::move(handle)); 58 iter->second->BindInterface(connection_, interface_name, std::move(handle));
68 } else if (connection_ && !connection_->AllowsInterface(interface_name)) { 59 } else if (connection_ && !connection_->AllowsInterface(interface_name)) {
69 LOG(ERROR) << "Connection CapabilityFilter prevented binding to " 60 LOG(ERROR) << "Connection CapabilityFilter prevented binding to "
70 << "interface: " << interface_name << " connection_name:" 61 << "interface: " << interface_name << " connection_name:"
71 << connection_->GetConnectionName() << " remote_name:" 62 << connection_->GetConnectionName() << " remote_name:"
72 << connection_->GetRemoteIdentity().name(); 63 << connection_->GetRemoteIdentity().name();
73 } else if (!default_binder_.is_null()) {
74 default_binder_.Run(interface_name, std::move(handle));
75 } 64 }
76 } 65 }
77 66
78 bool InterfaceRegistry::SetInterfaceBinderForName( 67 bool InterfaceRegistry::SetInterfaceBinderForName(
79 std::unique_ptr<InterfaceBinder> binder, 68 std::unique_ptr<InterfaceBinder> binder,
80 const std::string& interface_name) { 69 const std::string& interface_name) {
81 if (!connection_ || 70 if (!connection_ ||
82 (connection_ && connection_->AllowsInterface(interface_name))) { 71 (connection_ && connection_->AllowsInterface(interface_name))) {
83 RemoveInterface(interface_name); 72 RemoveInterface(interface_name);
84 name_to_binder_[interface_name] = std::move(binder); 73 name_to_binder_[interface_name] = std::move(binder);
85 return true; 74 return true;
86 } 75 }
87 return false; 76 return false;
88 } 77 }
89 78
90 } // namespace shell 79 } // namespace shell
OLDNEW
« no previous file with comments | « services/shell/public/cpp/lib/interface_provider.cc ('k') | services/shell/public/cpp/lib/service_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698