Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 213823003: Preserve account selection on rotating the device in Chromoting Android app (Closed)

Created:
6 years, 9 months ago by Lambros
Modified:
6 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Preserve account selection on rotating the device in Chromoting Android app This uses a different method of reloading the accounts spinner if the device is rotated. R=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259770

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 3 chunks +6 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Lambros
6 years, 9 months ago (2014-03-27 00:23:05 UTC) #1
Jamie
lgtm https://codereview.chromium.org/213823003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/213823003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode219 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:219: // orientation. Is this comment still accurate?
6 years, 9 months ago (2014-03-27 02:06:32 UTC) #2
Lambros
https://codereview.chromium.org/213823003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/213823003/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode219 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:219: // orientation. On 2014/03/27 02:06:32, Jamie wrote: > Is ...
6 years, 9 months ago (2014-03-27 02:13:18 UTC) #3
Lambros
6 years, 9 months ago (2014-03-27 03:02:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r259770 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698