Preserve account selection on rotating the device in Chromoting Android app

remoting/android/java/src/org/chromium/chromoting/Chromoting.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.accounts.Account;
 import android.accounts.AccountManager;
 import android.accounts.AccountManagerCallback;
 import android.accounts.AccountManagerFuture;
@@ skipping 43 matching lines @@
     /** Web page to be displayed when user triggers the hyperlink for setting up hosts. */
     private static final String HOST_SETUP_URL =
             "https://support.google.com/chrome/answer/1649523";
 
     /** User's account details. */
     private Account mAccount;
 
     /** List of accounts on the system. */
     private Account[] mAccounts;
 
+    /** SpinnerAdapter used in the action bar for selecting accounts. */
+    private AccountsAdapter mAccountsAdapter;
+
     /** Account auth token. */
     private String mToken;
 
     /** Helper for fetching the host list. */
     private HostListLoader mHostListLoader;
 
     /** List of hosts. */
     private HostInfo[] mHosts = new HostInfo[0];
 
     /** Refresh button. */
@@ skipping 110 matching lines @@
             // first account arbitrarily.
             index = 0;
             mAccount = mAccounts[0];
         }
 
         if (mAccounts.length == 1) {
             getActionBar().setDisplayShowTitleEnabled(true);
             getActionBar().setTitle(R.string.mode_me2me);
             getActionBar().setSubtitle(mAccount.name);
         } else {
-            AccountsAdapter adapter = new AccountsAdapter(this, mAccounts);
+            mAccountsAdapter = new AccountsAdapter(this, mAccounts);
             getActionBar().setNavigationMode(ActionBar.NAVIGATION_MODE_LIST);
-            getActionBar().setListNavigationCallbacks(adapter, this);
+            getActionBar().setListNavigationCallbacks(mAccountsAdapter, this);
             getActionBar().setSelectedNavigationItem(index);
         }
 
         refreshHostList();
     }
 
     /** Called when the activity is finally finished. */
     @Override
     public void onDestroy() {
         super.onDestroy();
         JniInterface.disconnectFromHost();
     }
 
     /** Called when the display is rotated (as registered in the manifest). */
     @Override
     public void onConfigurationChanged(Configuration newConfig) {
         super.onConfigurationChanged(newConfig);
 
         // Reload the spinner resources, since the font sizes are dependent on the screen
         // orientation.

[Jamie, 2014/03/27 02:06:32]

Is this comment still accurate?

[Lambros, 2014/03/27 02:13:19]

Yes. The font styles in the spinner are defined to be a different size in
landscape mode to account for the reduced action-bar height on some devices.
This code ensures that the spinner views get reloaded, so the fonts get resized.

         if (mAccounts.length != 1) {
-            AccountsAdapter adapter = new AccountsAdapter(this, mAccounts);
-            getActionBar().setListNavigationCallbacks(adapter, this);
+            mAccountsAdapter.notifyDataSetChanged();
         }
     }
 
     /** Called to initialize the action bar. */
     @Override
     public boolean onCreateOptionsMenu(Menu menu) {
         getMenuInflater().inflate(R.menu.chromoting_actionbar, menu);
         mRefreshButton = menu.findItem(R.id.actionbar_directoryrefresh);
 
         if (mAccount == null) {
@@ skipping 205 matching lines @@
                 // Unreachable, but required by Google Java style and findbugs.
                 assert false : "Unreached";
         }
 
         if (dismissProgress && mProgressIndicator != null) {
             mProgressIndicator.dismiss();
             mProgressIndicator = null;
         }
     }
 }