Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2137953002:
Duplicate shipping option identifiers should throw TypeError. (Closed)
|
Created:
4 years, 5 months ago by pals Modified:
4 years, 5 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews, blink-reviews, haraken Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDuplicate shipping option identifiers should throw TypeError.
BUG=587995
Committed: https://crrev.com/0f7bc8677b8f04c46bbbd574b98faa5a2161769a
Cr-Commit-Position: refs/heads/master@{#405002}
Patch Set 1 #Patch Set 2 : patch2 #
Total comments: 1
Patch Set 3 : patch3 #
Messages
Total messages: 27 (18 generated)
The CQ bit was checked by sanjoy.pal@samsung.com to run a CQ dry run
Description was changed from ========== Duplicate shipping option identifiers should throw TypeError. BUG=587995 ========== to ========== Duplicate shipping option identifiers should throw TypeError. BUG=587995 ==========
sanjoy.pal@samsung.com changed reviewers: + rouslan@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sanjoy.pal@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm % nit https://codereview.chromium.org/2137953002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2137953002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:214: } nit: newline between the blocks.
The CQ bit was checked by sanjoy.pal@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2137953002/#ps40001 (title: "patch3")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sanjoy.pal@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sanjoy.pal@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Duplicate shipping option identifiers should throw TypeError. BUG=587995 ========== to ========== Duplicate shipping option identifiers should throw TypeError. BUG=587995 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Duplicate shipping option identifiers should throw TypeError. BUG=587995 ========== to ========== Duplicate shipping option identifiers should throw TypeError. BUG=587995 Committed: https://crrev.com/0f7bc8677b8f04c46bbbd574b98faa5a2161769a Cr-Commit-Position: refs/heads/master@{#405002} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0f7bc8677b8f04c46bbbd574b98faa5a2161769a Cr-Commit-Position: refs/heads/master@{#405002} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
