Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2137953002: Duplicate shipping option identifiers should throw TypeError. (Closed)

Created:
4 years, 5 months ago by pals
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Duplicate shipping option identifiers should throw TypeError. BUG=587995 Committed: https://crrev.com/0f7bc8677b8f04c46bbbd574b98faa5a2161769a Cr-Commit-Position: refs/heads/master@{#405002}

Patch Set 1 #

Patch Set 2 : patch2 #

Total comments: 1

Patch Set 3 : patch3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/payments/payment-request-interface.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
pals
PTAL.
4 years, 5 months ago (2016-07-12 04:56:16 UTC) #9
please use gerrit instead
lgtm % nit https://codereview.chromium.org/2137953002/diff/20001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2137953002/diff/20001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp#newcode214 third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:214: } nit: newline between the blocks.
4 years, 5 months ago (2016-07-12 10:01:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137953002/40001
4 years, 5 months ago (2016-07-12 11:18:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/254018)
4 years, 5 months ago (2016-07-12 12:38:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137953002/40001
4 years, 5 months ago (2016-07-12 13:19:11 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191201)
4 years, 5 months ago (2016-07-12 14:46:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137953002/40001
4 years, 5 months ago (2016-07-13 03:22:48 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 04:10:59 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:12:36 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0f7bc8677b8f04c46bbbd574b98faa5a2161769a
Cr-Commit-Position: refs/heads/master@{#405002}

Powered by Google App Engine
This is Rietveld 408576698