Duplicate shipping option identifiers should throw TypeError.

third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentTestHelper.h"
 
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/Document.h"
 #include "modules/payments/PaymentCurrencyAmount.h"
 #include "modules/payments/PaymentMethodData.h"
 #include "platform/heap/HeapAllocator.h"
 
 namespace blink {
 namespace {
 
+static int gUniqueId = 0;
 // PaymentItem and PaymentShippingOption have identical structure
 // except for the "id" field, which is present only in PaymentShippingOption.
 template <typename PaymentItemOrPaymentShippingOption>
 void setValues(PaymentItemOrPaymentShippingOption& original, PaymentTestDataToChange data, PaymentTestModificationType modificationType, const String& valueToUse)
 {
     PaymentCurrencyAmount itemAmount;
     if (data == PaymentTestDataCurrencyCode) {
         if (modificationType == PaymentTestOverwriteValue)
             itemAmount.setCurrency(valueToUse);
     } else {
@@ skipping 27 matching lines @@
     return item;
 }
 
 PaymentShippingOption buildShippingOptionForTest(PaymentTestDataToChange data, PaymentTestModificationType modificationType, const String& valueToUse)
 {
     PaymentShippingOption shippingOption;
     if (data == PaymentTestDataId) {
         if (modificationType == PaymentTestOverwriteValue)
             shippingOption.setId(valueToUse);
     } else {
-        shippingOption.setId("id");
+        shippingOption.setId("id" + String::number(gUniqueId++));
     }
     setValues(shippingOption, data, modificationType, valueToUse);
     return shippingOption;
 }
 
 PaymentDetailsModifier buildPaymentDetailsModifierForTest(PaymentTestDetailToChange detail, PaymentTestDataToChange data, PaymentTestModificationType modificationType, const String& valueToUse)
 {
     PaymentItem total;
     if (detail == PaymentTestDetailModifierTotal)
         total = buildPaymentItemForTest(data, modificationType, valueToUse);
@@ skipping 35 matching lines @@
 
     PaymentDetailsModifier modifier;
     if (detail == PaymentTestDetailModifierTotal || detail == PaymentTestDetailModifierItem)
         modifier = buildPaymentDetailsModifierForTest(detail, data, modificationType, valueToUse);
     else
         modifier = buildPaymentDetailsModifierForTest();
 
     PaymentDetails result;
     result.setTotal(total);
     result.setDisplayItems(HeapVector<PaymentItem>(1, item));
-    result.setShippingOptions(HeapVector<PaymentShippingOption>(2, shippingOption));
+    result.setShippingOptions(HeapVector<PaymentShippingOption>(1, shippingOption));
     result.setModifiers(HeapVector<PaymentDetailsModifier>(1, modifier));
 
     return result;
 }
 
 HeapVector<PaymentMethodData> buildPaymentMethodDataForTest()
 {
     HeapVector<PaymentMethodData> methodData(1, PaymentMethodData());
     methodData[0].setSupportedMethods(Vector<String>(1, "foo"));
     return methodData;
@@ skipping 42 matching lines @@
 {
     ON_CALL(*this, call(testing::_)).WillByDefault(testing::ReturnArg<0>());
 }
 
 v8::Local<v8::Function> PaymentRequestMockFunctionScope::MockFunction::bind()
 {
     return bindToV8Function();
 }
 
 } // namespace blink