Source/core/html/HTMLEmbedElement.idl - Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLEmbedElement.idl

Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Working Version Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/V8DOMActivityLogger.h ('K') | « Source/bindings/v8/V8DOMActivityLogger.h ('k') | Source/core/html/HTMLIFrameElement.idl » ('j') | public/web/WebDOMActivityLogger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLEmbedElement.idl

diff --git a/Source/core/html/HTMLEmbedElement.idl b/Source/core/html/HTMLEmbedElement.idl

index d354a74abc692b467dd317439d6017547350d1dd..c9d9e29de6d4a09b4aa855e091b18e15a3ca3808 100644

--- a/Source/core/html/HTMLEmbedElement.idl

+++ b/Source/core/html/HTMLEmbedElement.idl

@@ -24,7 +24,7 @@

[Reflect] attribute DOMString align;

[Reflect] attribute DOMString height;

[Reflect] attribute DOMString name;

- [Reflect, URL, PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds] attribute DOMString src;

+ [Reflect, URL, PerWorldBindings, ActivityLogging=SetterForIsolatedWorldsIncludeOldValueForSetter] attribute DOMString src;

abarth-chromium 2014/04/22 23:35:51 Can't someone circumvent this by just using setAtt

Devlin 2014/04/23 01:10:03 Sadly, yes (neither caused nor helped by this CL).

[Reflect] attribute DOMString type;

[Reflect] attribute DOMString width;

[Custom, NotEnumerable] getter boolean (unsigned long index);

« Source/bindings/v8/V8DOMActivityLogger.h ('K') | « Source/bindings/v8/V8DOMActivityLogger.h ('k') | Source/core/html/HTMLIFrameElement.idl » ('j') | public/web/WebDOMActivityLogger.h » ('J')