Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: Source/bindings/v8/V8DOMActivityLogger.h

Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Working Version Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8DOMActivityLogger.h
diff --git a/Source/bindings/v8/V8DOMActivityLogger.h b/Source/bindings/v8/V8DOMActivityLogger.h
index 54c653d665bc1083822a656fb78358120700faec..13ddd2ac9faceb232acbb7b5a71c252cf9a671df 100644
--- a/Source/bindings/v8/V8DOMActivityLogger.h
+++ b/Source/bindings/v8/V8DOMActivityLogger.h
@@ -41,8 +41,13 @@ class V8DOMActivityLogger {
public:
virtual ~V8DOMActivityLogger() { }
+ // DEPRECATED: Only here for chrome compilation while the new patch goes through.
virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value>* argv, const String& extraInfo) { }
abarth-chromium 2014/04/22 23:35:51 Why is this needed to chrome compilation? Code ou
Devlin 2014/04/23 01:10:03 Whoops! Meant to only leave in the one in public/
+ virtual void logGetter(const String& apiName) { }
+ virtual void logSetter(const String& apiName, const v8::Handle<v8::Value>& newValue, const v8::Handle<v8::Value>& oldValue) { }
+ virtual void logMethod(const String& apiName, int argc, const v8::Handle<v8::Value>* argv) { }
+
// Associates a logger with the world identified by worldId (worlId may be 0
// identifying the main world).
static void setActivityLogger(int worldId, PassOwnPtr<V8DOMActivityLogger>);

Powered by Google App Engine
This is Rietveld 408576698