Pass current value of attributes to WebDOMActivityLogger Setter logs.

Source/bindings/scripts/v8_utilities.py

Index: Source/bindings/scripts/v8_utilities.py
diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py
index 67b03209fbab876c98118ed9ae23974e75fc88f5..38da78aa775c30687ab035d8af00b75dcf0b2470 100644
--- a/Source/bindings/scripts/v8_utilities.py
+++ b/Source/bindings/scripts/v8_utilities.py
@@ -149,6 +149,12 @@ def activity_logging_world_list(member, access_type=None):
     return set(['', 'ForMainWorld'])  # endswith('ForAllWorlds')
 
 
+def activity_old_value_for_setter(member):
+    """Returns true if the log of the setter should include the original value."""
+    return ('ActivityLogging' in member.extended_attributes and
+        member.extended_attributes['ActivityLogging']
+            .find('IncludeOldValueForSetter') != -1)

[abarth-chromium, 2014/04/22 23:35:51]

This line of code is a sign that IncludeOldValueForSetter should be a separate
IDL attribute.

[Devlin, 2014/04/23 01:10:03]

Done.

[Nils Barth (inactive), 2014/04/23 01:12:02]

Python note:
You can use |in| for substring searches:
'IncludeOldValueForSetter' in member.extended_attributes['ActivityLogging']

Anyway, as Adam notes, we should split up ActivityLogging
(I'd suggest into a list of values), and then we can use the
existing utility function
v8_utilites.has_extended_attribute_value
...to check the list, as:
has_extended_attribute_value(member, 'ActivityLogging',
'IncludeOldValueForSetter')
(inline, no need for auxiliary function)

[Devlin, 2014/04/23 01:31:43]

Already fixed, but thanks for the tips! :)

+
 # [CallWith]
 CALL_WITH_ARGUMENTS = {
     'ScriptState': 'state',