Pass current value of attributes to WebDOMActivityLogger Setter logs.

Source/bindings/scripts/v8_utilities.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 131 matching lines @@
     has_logging = (activity_logging.startswith('For') or
                    (access_type and activity_logging.startswith(access_type)))
     if not has_logging:
         return set()
     includes.add('bindings/v8/V8DOMActivityLogger.h')
     if activity_logging.endswith('ForIsolatedWorlds'):
         return set([''])
     return set(['', 'ForMainWorld'])  # endswith('ForAllWorlds')
 
 
+def activity_old_value_for_setter(member):
+    """Returns true if the log of the setter should include the original value."""
+    return ('ActivityLogging' in member.extended_attributes and
+        member.extended_attributes['ActivityLogging']
+            .find('IncludeOldValueForSetter') != -1)

[abarth-chromium, 2014/04/22 23:35:51]

This line of code is a sign that IncludeOldValueForSetter should be a separate
IDL attribute.

[Devlin, 2014/04/23 01:10:03]

Done.

[Nils Barth (inactive), 2014/04/23 01:12:02]

Python note:
You can use |in| for substring searches:
'IncludeOldValueForSetter' in member.extended_attributes['ActivityLogging']

Anyway, as Adam notes, we should split up ActivityLogging
(I'd suggest into a list of values), and then we can use the
existing utility function
v8_utilites.has_extended_attribute_value
...to check the list, as:
has_extended_attribute_value(member, 'ActivityLogging',
'IncludeOldValueForSetter')
(inline, no need for auxiliary function)

[Devlin, 2014/04/23 01:31:43]

Already fixed, but thanks for the tips! :)

+
 # [CallWith]
 CALL_WITH_ARGUMENTS = {
     'ScriptState': 'state',
     'NewScriptState': 'state',
     'ExecutionContext': 'scriptContext',
     'ScriptArguments': 'scriptArguments.release()',
     'ActiveWindow': 'callingDOMWindow(info.GetIsolate())',
     'FirstWindow': 'enteredDOMWindow(info.GetIsolate())',
 }
 # List because key order matters, as we want arguments in deterministic order
@@ skipping 82 matching lines @@
 
     The returned function checks if a method/attribute is enabled.
     Given extended attribute RuntimeEnabled=FeatureName, return:
         RuntimeEnabledFeatures::{featureName}Enabled
     """
     extended_attributes = definition_or_member.extended_attributes
     if 'RuntimeEnabled' not in extended_attributes:
         return None
     feature_name = extended_attributes['RuntimeEnabled']
     return 'RuntimeEnabledFeatures::%sEnabled' % uncapitalize(feature_name)