third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing the code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js b/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

index a91e6bebfdd35680c0e663ab67ed627c9ec33c60..65cc06420a4ad21c4b02994887cc7702ed3333d1 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js

@@ -929,7 +929,7 @@ WebInspector.Spectrum.PaletteGenerator = function(callback)

/** @type {!Map.<string, number>} */

this._frequencyMap = new Map();

var stylesheetPromises = [];

- for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page)) {

+ for (var target of WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser)) {

var cssModel = WebInspector.CSSModel.fromTarget(target);

for (var stylesheet of cssModel.allStyleSheets())

stylesheetPromises.push(new Promise(this._processStylesheet.bind(this, stylesheet)));