third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing the code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js ('K') | « third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/InspectElementModeController.js » ('j') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

index 0d134561edf094872a51bd9f15e6f1421e81614d..51034788644a6eadc6f28e06f140fb82bb8116cb 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -266,8 +266,8 @@ WebInspector.ConsoleView.prototype = {

targetAdded: function(target)

{

this._viewport.invalidate();

- if (WebInspector.targetManager.targets().length > 1 && WebInspector.targetManager.mainTarget().isPage())

- this._showAllMessagesCheckbox.element.classList.toggle("hidden", false);

+ var shouldShowCheck = WebInspector.targetManager.targets(WebInspector.Target.Capability.Browser).length > 1;

dgozman 2016/07/13 00:08:29 Capability.Browser -> Capability.JS

dgozman 2016/07/13 00:08:29 haveMultipleContexts

eostroukhov-old 2016/07/13 00:36:29 Done.

dgozman 2016/07/13 00:41:52 Not done :-)

+ this._showAllMessagesCheckbox.element.classList.toggle("hidden", shouldShowCheck);

dgozman 2016/07/13 00:08:29 !haveMultipleContexts

eostroukhov-old 2016/07/13 00:36:29 Done.

/**