third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [DevTools] Replace target type with capabilities Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js » ('j') | third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

index 8393d89a0911f31f5e8db00931aa8c719ed399ba..b07cdb93a2ed9a1ac0d044e708d2fe7109684845 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

@@ -13,7 +13,7 @@ function test()

var sniffer = {

targetAdded: function(target)

{

- if (target.isServiceWorker()) {

+ if (!target.hasBrowserDomains() && !target.hasJSDomains()) {

resolve();

WebInspector.targetManager.unobserveTargets(sniffer);

}