Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [DevTools] Replace target type with capabilities Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
index 4d236ae352e6e62846b50974950fe75914728896..5791cca14332f4737cf8960540d3d5e34bfc9631 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
@@ -19,7 +19,11 @@ InspectorTest.waitForServiceWorker = function(callback)
{
function isRightTarget(target)
{
- return target.isDedicatedWorker() && target.parentTarget() && target.parentTarget().isServiceWorker();
+ if (!target.hasBrowserDomains() && target.hasJSDomains()) {
dgozman 2016/07/12 00:34:10 Let's add InspectorTest.is{DedicatedWorker,Service
eostroukhov-old 2016/07/12 21:46:15 Done.
+ var parent = target.parentTarget();
+ return !parent.hasBrowserDomains() && !parent.hasJSDomains() && parent.hasNetworkDomains();
+ }
+ return false;
}
WebInspector.targetManager.observeTargets({

Powered by Google App Engine
This is Rietveld 408576698