DevTools: automatically populate 'More tools' submenu with the drawer views.

third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1255 matching lines @@
     {
         /** @type {!Map.<string, !Runtime.Extension>} */
         this._extensions = new Map();
         var extensions = self.runtime.extensions(this._extensionPoint);
 
         for (var i = 0; i < extensions.length; ++i) {
             var id = extensions[i].descriptor()["name"];
             this._extensions.set(id, extensions[i]);
             if (this._isPermanentTab(id))
                 this._appendTab(extensions[i]);
-        }
-
-        for (var i = 0; i < extensions.length; i++) {

[dgozman, 2016/07/09 01:12:15]

This code made it so all permanent tabs are always first. Please revert.

[pfeldman, 2016/07/09 01:37:03]

We are controlling this using extension order.

-            var id = extensions[i].descriptor()["name"];
-            if (this._isCloseableTab(id) && this._closeableTabSetting.get()[id])
+            else if (this._isCloseableTab(id) && this._closeableTabSetting.get()[id])
                 this._appendTab(extensions[i]);
         }
     },
 
     /**
      * @param {string} id
      * @return {boolean}
      */
     _isPermanentTab: function(id)
     {
@@ skipping 15 matching lines @@
         toolbar.appendToolbarItem(new WebInspector.ToolbarMenuButton(this._appendTabsToMenu.bind(this)));
         this._tabbedPane.insertBeforeTabStrip(toolbar.element);
         this._tabbedPane.disableOverflowMenu();
     },
 
     /**
      * @param {!WebInspector.ContextMenu} contextMenu
      */
     _appendTabsToMenu: function(contextMenu)
     {
-        for (var id of this._extensions.keysArray().filter(this._isPermanentTab.bind(this))) {
-            var title = WebInspector.UIString(this._extensions.get(id).title(WebInspector.platform()));
-            contextMenu.appendItem(title, this.showTab.bind(this, id));
-        }
-        for (var id of this._extensions.keysArray().filter(this._isCloseableTab.bind(this))) {
-            var title = WebInspector.UIString(this._extensions.get(id).title(WebInspector.platform()));
-            contextMenu.appendItem(title, this.showTab.bind(this, id));
+        var extensions = self.runtime.extensions(this._extensionPoint, undefined, true);
+        for (var extension of extensions) {
+            var title = WebInspector.UIString(extension.title(WebInspector.platform()));
+            contextMenu.appendItem(title, this.showTab.bind(this, extension.descriptor()["name"]));
         }
     },
 
     /**
      * @param {!Runtime.Extension} extension
      */
     _appendTab: function(extension)
     {
         var descriptor = extension.descriptor();
         var id = descriptor["name"];
@@ skipping 97 matching lines @@
             if (this._viewCallback && view)
                 this._viewCallback(id, view);
             var shouldFocus = this._tabbedPane.visibleView.element.isSelfOrAncestor(WebInspector.currentFocusElement());
             this._tabbedPane.changeTabView(id, view);
             if (shouldFocus)
                 view.focus();
             return view;
         }
     }
 }