chrome/installer/mac/app/testing/requestCheck.dtd - Issue 2137743002: Added test files for SystemInfo.m and OmahaXMLRequest.m.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/testing/requestCheck.dtd

Issue 2137743002: Added test files for SystemInfo.m and OmahaXMLRequest.m. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Completed both test files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/mac/app/testing/requestCheck.dtd

diff --git a/chrome/installer/mac/app/testing/requestCheck.dtd b/chrome/installer/mac/app/testing/requestCheck.dtd

new file mode 100644

index 0000000000000000000000000000000000000000..e4cff8b2d76198fab89690a6c2830bbd9bbe401f

--- /dev/null

+++ b/chrome/installer/mac/app/testing/requestCheck.dtd

@@ -0,0 +1,12 @@

+<!ELEMENT request (os, app)>

Elly Fong-Jones 2016/07/19 18:45:58 can you please comment this file heavily? I (and I

Anna Zeng 2016/07/22 16:58:02 Done.

+<!ATTLIST request protocol CDATA #REQUIRED>

+<!ELEMENT os (#PCDATA)>

+<!ATTLIST os platform CDATA #REQUIRED>

+<!ATTLIST os version CDATA #IMPLIED>

+<!ATTLIST os arch CDATA #IMPLIED>

+<!ATTLIST os sp CDATA #IMPLIED>

+<!ELEMENT app (updatecheck)>

+<!ATTLIST app appid CDATA #REQUIRED>

+<!ATTLIST app version CDATA #REQUIRED>

+<!ATTLIST app lang CDATA #REQUIRED>

+<!ELEMENT updatecheck (#PCDATA)>

« chrome/installer/mac/app/testing/SystemInfo_test.mm ('K') | « chrome/installer/mac/app/testing/SystemInfo_test.mm ('k') | no next file » | no next file with comments »