chrome/installer/mac/app/testing/requestCheck.dtd - Issue 2137743002: Added test files for SystemInfo.m and OmahaXMLRequest.m.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mac/app/testing/requestCheck.dtd

Issue 2137743002: Added test files for SystemInfo.m and OmahaXMLRequest.m. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Completed both test files Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!ELEMENT request (os, app)>
	Elly Fong-Jones 2016/07/19 18:45:58 can you please comment this file heavily? I (and I can you please comment this file heavily? I (and I think most of the team) can't read XML DTDs. Anna Zeng 2016/07/22 16:58:02 Done. Show quoted text On 2016/07/19 18:45:58, Elly Jones wrote: > can you please comment this file heavily? I (and I think most of the team) can't > read XML DTDs. Done.
	2 <!ATTLIST request protocol CDATA #REQUIRED>

	3 <!ELEMENT os (#PCDATA)>

	4 <!ATTLIST os platform CDATA #REQUIRED>

	5 <!ATTLIST os version CDATA #IMPLIED>

	6 <!ATTLIST os arch CDATA #IMPLIED>

	7 <!ATTLIST os sp CDATA #IMPLIED>

	8 <!ELEMENT app (updatecheck)>

	9 <!ATTLIST app appid CDATA #REQUIRED>

	10 <!ATTLIST app version CDATA #REQUIRED>

	11 <!ATTLIST app lang CDATA #REQUIRED>

	12 <!ELEMENT updatecheck (#PCDATA)>

OLD	NEW

« chrome/installer/mac/app/testing/SystemInfo_test.mm ('K') | « chrome/installer/mac/app/testing/SystemInfo_test.mm ('k') | no next file » | no next file with comments »