Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6591)

Unified Diff: chrome/installer/mac/app/BUILD.gn

Issue 2137743002: Added test files for SystemInfo.m and OmahaXMLRequest.m. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Completed both test files Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/BUILD.gn
diff --git a/chrome/installer/mac/app/BUILD.gn b/chrome/installer/mac/app/BUILD.gn
index aa2123f2c6ce5a2b5d1ae8e5cdcae118c36435af..97f6451e260f13272017209de9d6f22fdc833823 100644
--- a/chrome/installer/mac/app/BUILD.gn
+++ b/chrome/installer/mac/app/BUILD.gn
@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-executable("downloader") {
+static_library("project") {
Mark Mentovai 2016/07/15 21:56:08 We should come up with better names, since these a
Anna Zeng 2016/07/22 16:58:01 Acknowledged.
Anna Zeng 2016/07/22 16:58:01 Done.
sources = [
"DownloadDelegate.m",
"Downloader.m",
@@ -11,7 +11,29 @@ executable("downloader") {
"OmahaXMLParser.m",
"OmahaXMLRequest.m",
"SystemInfo.m",
+ ]
+}
+
+executable("downloader") {
+ sources = [
"main.m",
]
+ deps = [
+ ":project",
+ ]
+ libs = [ "Foundation.framework" ]
+}
+
+executable("downloader_test") {
Mark Mentovai 2016/07/15 21:56:08 Probably just mac_installer_test, and we can have
Anna Zeng 2016/07/22 16:58:01 Done.
Anna Zeng 2016/07/22 16:58:01 Acknowledged.
+ testonly = true
+ sources = [
+ "//testing/gtest/src/gtest_main.cc",
Mark Mentovai 2016/07/15 21:56:08 I think you want to depend on the gtest_main sourc
Anna Zeng 2016/07/22 16:58:01 Done.
Anna Zeng 2016/07/22 16:58:01 Acknowledged.
+ "testing/OmahaXMLRequest_test.mm",
+ "testing/SystemInfo_test.mm",
+ ]
+ deps = [
+ ":project",
+ "//testing/gtest",
+ ]
libs = [ "Foundation.framework" ]
}

Powered by Google App Engine
This is Rietveld 408576698