Added test files for SystemInfo.m and OmahaXMLRequest.m.

chrome/installer/mac/app/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-executable("downloader") {
+static_library("project") {

[Mark Mentovai, 2016/07/15 21:56:08]

We should come up with better names, since these are kind of globally namespaced
within all of Chrome. Prefix things with mac_installer?

[Anna Zeng, 2016/07/22 16:58:01]

Acknowledged.

[Anna Zeng, 2016/07/22 16:58:01]

Done.

   sources = [
     "DownloadDelegate.m",
     "Downloader.m",
     "NetworkCommunication.m",
     "OmahaCommunication.m",
     "OmahaXMLParser.m",
     "OmahaXMLRequest.m",
     "SystemInfo.m",
+  ]
+}
+
+executable("downloader") {
+  sources = [
     "main.m",
   ]
+  deps = [
+    ":project",
+  ]
   libs = [ "Foundation.framework" ]
 }
+
+executable("downloader_test") {

[Mark Mentovai, 2016/07/15 21:56:08]

Probably just mac_installer_test, and we can have all of our tests run from a
single executable.

[Anna Zeng, 2016/07/22 16:58:01]

Done.

[Anna Zeng, 2016/07/22 16:58:01]

Acknowledged.

+  testonly = true
+  sources = [
+    "//testing/gtest/src/gtest_main.cc",

[Mark Mentovai, 2016/07/15 21:56:08]

I think you want to depend on the gtest_main source set, which already compiles
this, rather than compiling another copy in this target.

[Anna Zeng, 2016/07/22 16:58:01]

Done.

[Anna Zeng, 2016/07/22 16:58:01]

Acknowledged.

+    "testing/OmahaXMLRequest_test.mm",
+    "testing/SystemInfo_test.mm",
+  ]
+  deps = [
+    ":project",
+    "//testing/gtest",
+  ]
+  libs = [ "Foundation.framework" ]
+}