components/precache/content/precache_manager.cc - Issue 2137593002: PrecacheFetcher::CancelPrecaching should run in the main UI thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/precache/content/precache_manager.cc

Issue 2137593002: PrecacheFetcher::CancelPrecaching should run in the main UI thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java ('k') | components/precache/core/precache_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/precache/content/precache_manager.cc

diff --git a/components/precache/content/precache_manager.cc b/components/precache/content/precache_manager.cc

index 9a81fbb032b3e47ee7de0748794ec3c30ea0c096..2f896f3e3b9194778e4e11bd4403c55fa48c5a95 100644

--- a/components/precache/content/precache_manager.cc

+++ b/components/precache/content/precache_manager.cc

@@ -197,12 +197,12 @@ void PrecacheManager::CancelPrecaching() {

if (precache_fetcher_) {

std::unique_ptr<PrecacheUnfinishedWork> unfinished_work =

precache_fetcher_->CancelPrecaching();

- BrowserThread::PostTask(

- BrowserThread::DB,

- FROM_HERE,

- base::Bind(&PrecacheDatabase::SaveUnfinishedWork,

- precache_database_->GetWeakPtr(),

- base::Passed(&unfinished_work)));

+ if (unfinished_work) {

+ BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,

+ base::Bind(&PrecacheDatabase::SaveUnfinishedWork,

+ precache_database_->GetWeakPtr(),

+ base::Passed(&unfinished_work)));

+ }

// Destroying the |precache_fetcher_| will cancel any fetch in progress.

precache_fetcher_.reset();

}