chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java - Issue 2137593002: PrecacheFetcher::CancelPrecaching should run in the main UI thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

Issue 2137593002: PrecacheFetcher::CancelPrecaching should run in the main UI thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java ('k') | components/precache/content/precache_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

index 613fcbeebfaa2890d05543e382c415a3bb3846f5..fbaf712cfc8212d0b8b3b93bf016dfadd8ad25f0 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

@@ -8,6 +8,7 @@ import android.content.Context;

import android.content.Intent;

import android.content.SharedPreferences.Editor;

import android.test.InstrumentationTestCase;

+import android.test.UiThreadTest;

import android.test.suitebuilder.annotation.SmallTest;

import com.google.android.gms.gcm.GcmNetworkManager;

@@ -194,6 +195,7 @@ public class PrecacheControllerTest extends InstrumentationTestCase {

}

@SmallTest

+ @UiThreadTest

@Feature({"Precache"})

public void testDeviceStateChangeCancels() {

verifyBeginPrecaching();

@@ -233,6 +235,7 @@ public class PrecacheControllerTest extends InstrumentationTestCase {

}

@SmallTest

+ @UiThreadTest

@Feature({"Precache"})

public void testTimeoutCancelsPrecaching() {

verifyBeginPrecaching();