Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2137553002: Rietveld: rely on CQ to decide whether to send email. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : make use cq_status_url #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -51 lines) Patch
M appengine/chromium_rietveld/codereview/models.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/chromium_rietveld/codereview/utils.py View 1 1 chunk +10 lines, -12 lines 0 comments Download
M appengine/chromium_rietveld/codereview/views.py View 1 2 4 chunks +27 lines, -21 lines 0 comments Download
M appengine/chromium_rietveld/tests/test_utils.py View 1 1 chunk +5 lines, -16 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
Sergiy Byelozyorov
LGTM
4 years, 5 months ago (2016-07-08 15:13:35 UTC) #3
tandrii(chromium)
PTAL - added cq_status_url companion CQ CL (internal): https://chromereviews.googleplex.com/463267013/
4 years, 5 months ago (2016-07-08 17:12:17 UTC) #8
Sergiy Byelozyorov
lgtm
4 years, 5 months ago (2016-07-09 05:27:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137553002/20001
4 years, 5 months ago (2016-07-11 18:00:48 UTC) #13
tandrii(chromium)
Internal version of the same patch: https://chromereviews.googleplex.com/468747013
4 years, 5 months ago (2016-07-11 18:03:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/infra/infra/+/b7213fb5c56cb0cb5db79b97259e9a5077819de8
4 years, 5 months ago (2016-07-11 18:15:29 UTC) #16
tandrii(chromium)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2142993002/ by tandrii@chromium.org. ...
4 years, 5 months ago (2016-07-12 15:44:06 UTC) #17
tandrii(chromium)
uploaded a fix, relanding...
4 years, 5 months ago (2016-07-12 15:46:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137553002/40001
4 years, 5 months ago (2016-07-12 16:35:12 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 16:38:07 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/b0b719d0fd23adefe1aab7942089e...

Powered by Google App Engine
This is Rietveld 408576698