Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: appengine/chromium_rietveld/codereview/utils.py

Issue 2137553002: Rietveld: rely on CQ to decide whether to send email. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/chromium_rietveld/codereview/models.py ('k') | appengine/chromium_rietveld/codereview/views.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_rietveld/codereview/utils.py
diff --git a/appengine/chromium_rietveld/codereview/utils.py b/appengine/chromium_rietveld/codereview/utils.py
index 1d3ae98b3c67585010c3bc5fb1e0eb4825c97600..4e2cfb2bdaffa0b46b8f5030afd3321e5b1961b2 100644
--- a/appengine/chromium_rietveld/codereview/utils.py
+++ b/appengine/chromium_rietveld/codereview/utils.py
@@ -96,21 +96,19 @@ def unify_linebreaks(text):
return text.replace('\r\n', '\n').replace('\r', '\n')
-_CQ_STATUS_REGEX = re.compile(
- '(dry run: )?CQ is trying da patch. Follow status at\s+'
- '(https://.+/patch-status/(.+/)?(\d+)/(\d+))\s*', re.I)
+_CQ_STATUS_URL_REGEX = re.compile(
+ '^https://.+/patch-status/(.+/)?(\d+)/(\d+)$', re.I)
-def parse_cq_status_url_message(msg):
- """Returns url, issue, patchset parsed from CQ status message.
+def parse_cq_status_url(url):
+ """Returns issue, patchset parsed from CQ status url.
- If parsing failed, returns None, None, None.
+ If parsing failed, returns None, None.
"""
- # Example of message, Dry Run prefix is optional.
- # Dry run: CQ is trying da patch. Follow status at
+ # Example of url:
# https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131593002/1
- match = _CQ_STATUS_REGEX.match(msg)
+ match = _CQ_STATUS_URL_REGEX.match(url)
if not match:
- return None, None, None
- _, url, _, issue, patchset = match.groups()
- return url, int(issue), int(patchset)
+ return None, None
+ _, issue, patchset = match.groups()
+ return int(issue), int(patchset)
« no previous file with comments | « appengine/chromium_rietveld/codereview/models.py ('k') | appengine/chromium_rietveld/codereview/views.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698