third_party/WebKit/Source/platform/testing/HistogramTester.h - Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/HistogramTester.h

Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use HistogramTester Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/platform/testing/HistogramTester.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/testing/HistogramTester.h

diff --git a/third_party/WebKit/Source/platform/testing/HistogramTester.h b/third_party/WebKit/Source/platform/testing/HistogramTester.h

index 16ccc152b9bd4f4c8991c0d2b245caf1ca04efc0..117a7caf4f370ed87cdf94fa2fa42bf9f605b1f8 100644

--- a/third_party/WebKit/Source/platform/testing/HistogramTester.h

+++ b/third_party/WebKit/Source/platform/testing/HistogramTester.h

@@ -22,6 +22,7 @@ public:

void expectUniqueSample(const std::string& name, base::HistogramBase::Sample, base::HistogramBase::Count) const;

void expectTotalCount(const std::string& name, base::HistogramBase::Count) const;

+ base::HistogramBase::Count histogramCount(const std::string& name, base::HistogramBase::Sample) const;

Ilya Sherman 2016/07/12 21:26:18 I'd prefer to keep this class analogous to base::H

private:

std::unique_ptr<base::HistogramTester> m_histogramTester;