third_party/WebKit/Source/platform/testing/HistogramTester.cpp - Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/HistogramTester.cpp

Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use HistogramTester Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/testing/HistogramTester.h ('K') | « third_party/WebKit/Source/platform/testing/HistogramTester.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/testing/HistogramTester.cpp

diff --git a/third_party/WebKit/Source/platform/testing/HistogramTester.cpp b/third_party/WebKit/Source/platform/testing/HistogramTester.cpp

index 043ca95221a76defaffd2f9a6ebca685ab7d872b..dd7f2a28e8afb2f3beb798d7efc67b9f22ed270d 100644

--- a/third_party/WebKit/Source/platform/testing/HistogramTester.cpp

+++ b/third_party/WebKit/Source/platform/testing/HistogramTester.cpp

@@ -23,4 +23,14 @@ void HistogramTester::expectTotalCount(const std::string& name, base::HistogramB

m_histogramTester->ExpectTotalCount(name, count);

}

+base::HistogramBase::Count HistogramTester::histogramCount(const std::string& name, base::HistogramBase::Sample bucket) const

+ std::vector<base::Bucket> histograms = m_histogramTester->GetAllSamples(name);

+ for (const auto& measuredBucket : histograms) {

+ if (bucket == measuredBucket.min)

+ return measuredBucket.count;

+ }

+ return 0;

} // namespace blink