Chromium Code Reviews
Help | Chromium Project | Sign in
(188)

Issue 213743012: [observe] provide notifications of keys/values changed for ObservableMap (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by John Messerly
Modified:
1 year, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[observe] provide notifications of keys/values changed for ObservableMap BUG= http://code.google.com/p/dart/issues/detail?id=15407 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -8 lines) Patch
M pkg/observe/lib/src/observable_map.dart View 5 chunks +16 lines, -0 lines 0 comments Download
M pkg/observe/test/observable_map_test.dart View 6 chunks +86 lines, -1 line 0 comments Download
M pkg/polymer_expressions/test/bindings_test.dart View 3 chunks +29 lines, -7 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
John Messerly
code changes are small, most of the diff is new tests :)
1 year, 4 months ago (2014-04-01 20:50:03 UTC) #1
Siggi Cherem (dart-lang)
nice. LGTM
1 year, 4 months ago (2014-04-01 23:25:09 UTC) #2
John Messerly
1 year, 4 months ago (2014-04-02 18:08:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34658 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5