Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 213743012: [observe] provide notifications of keys/values changed for ObservableMap (Closed)

Created:
6 years, 8 months ago by Jennifer Messerly
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[observe] provide notifications of keys/values changed for ObservableMap BUG= http://code.google.com/p/dart/issues/detail?id=15407 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -8 lines) Patch
M pkg/observe/lib/src/observable_map.dart View 5 chunks +16 lines, -0 lines 0 comments Download
M pkg/observe/test/observable_map_test.dart View 6 chunks +86 lines, -1 line 0 comments Download
M pkg/polymer_expressions/test/bindings_test.dart View 3 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
code changes are small, most of the diff is new tests :)
6 years, 8 months ago (2014-04-01 20:50:03 UTC) #1
Siggi Cherem (dart-lang)
nice. LGTM
6 years, 8 months ago (2014-04-01 23:25:09 UTC) #2
Jennifer Messerly
6 years, 8 months ago (2014-04-02 18:08:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34658 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698