content/common/gpu/gpu_command_buffer_stub.cc - Issue 213743003: Pass GL context bind_generates_resources flag to GPU Service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_command_buffer_stub.cc

Issue 213743003: Pass GL context bind_generates_resources flag to GPU Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fail GLES2Implementation::Initialize on bind_generates_resource between Client & Service. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc ('K') | « content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc ('k') | content/content_common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/gpu_command_buffer_stub.cc

diff --git a/content/common/gpu/gpu_command_buffer_stub.cc b/content/common/gpu/gpu_command_buffer_stub.cc

index b26757559392e78ff52656e50b5aafcf1d7b53f1..2becb4b9323a452afd2dea329144336e592752a6 100644

--- a/content/common/gpu/gpu_command_buffer_stub.cc

+++ b/content/common/gpu/gpu_command_buffer_stub.cc

@@ -139,15 +139,21 @@ GpuCommandBufferStub::GpuCommandBufferStub(

total_gpu_memory_(0) {

active_url_hash_ = base::Hash(active_url.possibly_invalid_spec());

FastSetActiveURL(active_url_, active_url_hash_);

+ gpu::gles2::ContextCreationAttribHelper attrib_parser;

+ attrib_parser.Parse(requested_attribs_);

if (share_group) {

context_group_ = share_group->context_group_;

+ DCHECK(context_group_->bind_generates_resource() ==

+ attrib_parser.bind_generates_resource_);

} else {

- context_group_ = new gpu::gles2::ContextGroup(

- mailbox_manager,

- image_manager,

- new GpuCommandBufferMemoryTracker(channel),

- NULL,

- true);

+ context_group_ =

+ new gpu::gles2::ContextGroup(mailbox_manager,

+ image_manager,

+ new GpuCommandBufferMemoryTracker(channel),

+ NULL,

+ attrib_parser.bind_generates_resource_);

}

use_virtualized_gl_context_ |=