content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc - Issue 213743003: Pass GL context bind_generates_resources flag to GPU Service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 213743003: Pass GL context bind_generates_resources flag to GPU Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fail GLES2Implementation::Initialize on bind_generates_resource between Client & Service. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

index 425990c8c752a926f1769e75dad328bffd12394e..6262fa0696905f6a1ac816e878166ecc41b76636 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

@@ -354,6 +354,8 @@ bool WebGraphicsContext3DCommandBufferImpl::InitializeCommandBuffer(

attribs.push_back(attributes_.failIfMajorPerformanceCaveat ? 1 : 0);

attribs.push_back(LOSE_CONTEXT_WHEN_OUT_OF_MEMORY);

attribs.push_back(lose_context_when_out_of_memory_ ? 1 : 0);

+ attribs.push_back(BIND_GENERATES_RESOURCES);

+ attribs.push_back(bind_generates_resources_ ? 1 : 0);

piman 2014/04/02 22:23:00 nit: how about removing bind_generates_resources_

vmiura 2014/04/02 22:44:25 Done.

attribs.push_back(NONE);

// Create a proxy to a command buffer in the GPU process.

« no previous file with comments | « no previous file | content/common/gpu/gpu_command_buffer_stub.cc » ('j') | no next file with comments »