Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2137233002: Closure: enforce Java version in roll script (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure: enforce Java version in roll script R=dpapad@chromium.org BUG=627195 NOTRY=true Committed: https://crrev.com/384105b95e25f71a1598cb6ebcb75e381668bd9f Cr-Commit-Position: refs/heads/master@{#404709}

Patch Set 1 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/closure_compiler/roll_closure_compiler View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
dpapad
lgtm
4 years, 5 months ago (2016-07-11 19:45:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137233002/20001
4 years, 5 months ago (2016-07-11 19:46:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-11 19:52:16 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 19:52:19 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 19:53:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/384105b95e25f71a1598cb6ebcb75e381668bd9f
Cr-Commit-Position: refs/heads/master@{#404709}

Powered by Google App Engine
This is Rietveld 408576698