Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/closure_compiler/roll_closure_compiler

Issue 2137233002: Closure: enforce Java version in roll script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/closure_compiler/roll_closure_compiler
diff --git a/third_party/closure_compiler/roll_closure_compiler b/third_party/closure_compiler/roll_closure_compiler
index 2f31c405990f94aaa74d125bc0a0e0d6a1b63436..f14a27de82e38bc071c1de6568c3d1e8a1b16fc4 100755
--- a/third_party/closure_compiler/roll_closure_compiler
+++ b/third_party/closure_compiler/roll_closure_compiler
@@ -6,6 +6,18 @@
# Download the newest version of Closure Compiler, build it and put into Chrome
# source tree. Also update externs/chrome_extensions.js.
+java -version 2>&1 | head -1 | egrep -q '\b1\.7'
+if [[ $? -ne 0 ]]; then
+ echo "This script requires Java 1.7" >&2
+ exit 1
+fi
+
+javac -version 2>&1 | egrep -q '\b1\.7'
+if [[ $? -ne 0 ]]; then
+ echo "This script requires JDK 1.7" >&2
+ exit 1
+fi
+
readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
readonly TEMP_DIR=$(mktemp -d)
readonly EXTERNS_DIR="${SCRIPT_DIR}/externs"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698