Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2137213004:
Timeline: rearrange trace completion logic for better extensibility (Closed)
|
Created:
4 years, 5 months ago by caseq Modified:
4 years, 5 months ago Reviewers:
alph CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTimeline: rearrange trace completion logic for better extensibility
This generalize the way we finialize timeline recording so that it's
easier to plug in extension trace providers.
BUG=620066
Committed: https://crrev.com/e522b2df678437a318b75c2be936e66fa0e1b827
Cr-Commit-Position: refs/heads/master@{#405918}
Patch Set 1 #
Total comments: 3
Patch Set 2 : review comments addressed #
Messages
Total messages: 27 (11 generated)
caseq@chromium.org changed reviewers: + alph@chromium.org
https://codereview.chromium.org/2137213004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js (right): https://codereview.chromium.org/2137213004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:80: WebInspector.targetManager.resumeAllTargets(); I think we still need this to have all targets resumed. so we can retrieve scripts. https://codereview.chromium.org/2137213004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:158: return targets.map(this._stopProfilingOnTarget, this); could you please revert it. https://codereview.chromium.org/2137213004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:211: this._resolveTracingStoppedPromise(); The name is misleading. This is not a promise.
Review comments addressed, ptal.
The CQ bit was checked by alph@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by caseq@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Timeline: rearrange trace completion logic for better extensibility This generalize the way we finialize timeline recording so that it's easier to plug in extension trace providers. BUG=620066 ========== to ========== Timeline: rearrange trace completion logic for better extensibility This generalize the way we finialize timeline recording so that it's easier to plug in extension trace providers. BUG=620066 Committed: https://crrev.com/e522b2df678437a318b75c2be936e66fa0e1b827 Cr-Commit-Position: refs/heads/master@{#405918} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e522b2df678437a318b75c2be936e66fa0e1b827 Cr-Commit-Position: refs/heads/master@{#405918} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
