Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html

Issue 2137213004: Timeline: rearrange trace completion logic for better extensibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html b/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html
index 02dc07ec6f3861206cd0b2d6a51c285f87e0e68e..2a2b00ebd007251b6df25c9c0cc4f06ad2720b33 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html
@@ -287,12 +287,10 @@ function test()
var timelineController = InspectorTest.timelineController();
timelineController._addCpuProfile(WebInspector.targetManager.mainTarget().id(), null, cpuProfile);
timelineController.traceEventsCollected(rawTraceEvents);
- timelineController.tracingComplete();
- InspectorTest.addSniffer(WebInspector.panels.timeline, "loadingComplete", () => {
- var events = InspectorTest.timelineModel().inspectedTargetEvents();
- events.forEach(e => InspectorTest.addResult(e.name + ": " + e.startTime + " " + (e.selfTime || 0).toFixed(2) + "/" + (e.duration || 0).toFixed(2)));
- InspectorTest.completeTest();
- });
+ timelineController._allSourcesFinished();
+ var events = InspectorTest.timelineModel().inspectedTargetEvents();
+ events.forEach(e => InspectorTest.addResult(e.name + ": " + e.startTime + " " + (e.selfTime || 0).toFixed(2) + "/" + (e.duration || 0).toFixed(2)));
+ InspectorTest.completeTest();
}
</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698