Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2137133002: Add new Cronet exception class for QUIC errors (Closed)

Created:
4 years, 5 months ago by mef
Modified:
4 years, 5 months ago
Reviewers:
mgersh, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add new Cronet exception class for QUIC errors Create a subclass of CronetException, called QuicException, which contains the detailed QUIC error code when it exists. Propagate the error code from NetErrorDetails through Cronet. For now, only UrlRequest reports the detailed error, not BidirectionalStream. BUG=614507 Review-Url: https://codereview.chromium.org/2069303002 Cr-Commit-Position: refs/heads/master@{#403525} (cherry picked from commit a8228bdbdd1840d925baf93067057daccae1e60a) R=mgersh@chromium.org, xunjieli@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/0c9d4e56fd928a79c5ec4f947771a5b9631f064a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -10 lines) Patch
M components/cronet/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/cronet/android/api/src/org/chromium/net/QuicException.java View 1 chunk +44 lines, -0 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/UrlRequestException.java View 2 chunks +9 lines, -1 line 0 comments Download
M components/cronet/android/cronet_bidirectional_stream_adapter.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/cronet/android/cronet_url_request_adapter.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java View 1 chunk +9 lines, -4 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java View 1 chunk +9 lines, -5 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java View 1 chunk +17 lines, -0 lines 0 comments Download
M components/cronet/android/url_request_error.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/android/url_request_error.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/test/url_request/url_request_failed_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/test/url_request/url_request_failed_job.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mef
PTAL. This is merging Miriam's CL into M53.
4 years, 5 months ago (2016-07-11 15:33:14 UTC) #2
xunjieli
lgtm
4 years, 5 months ago (2016-07-11 15:35:01 UTC) #3
mgersh
lgtm
4 years, 5 months ago (2016-07-11 15:43:15 UTC) #4
mef
4 years, 5 months ago (2016-07-11 15:47:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c9d4e56fd928a79c5ec4f947771a5b9631f064a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698