Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

Issue 2137133002: Add new Cronet exception class for QUIC errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
index 11474481dbfc04a05ca02b7dd125a7f4ee822303..86bde7ec8a3750e9af407afc19b58a71aa6a5fb1 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
@@ -582,13 +582,18 @@ class CronetBidirectionalStream extends BidirectionalStream {
@SuppressWarnings("unused")
@CalledByNative
- private void onError(
- int errorCode, int nativeError, String errorString, long receivedBytesCount) {
+ private void onError(int errorCode, int nativeError, int nativeQuicError, String errorString,
+ long receivedBytesCount) {
if (mResponseInfo != null) {
mResponseInfo.setReceivedBytesCount(receivedBytesCount);
}
- failWithException(new CronetException(
- "Exception in BidirectionalStream: " + errorString, errorCode, nativeError));
+ if (errorCode == UrlRequestException.ERROR_QUIC_PROTOCOL_FAILED) {
+ failWithException(new QuicException("Exception in BidirectionalStream: " + errorString,
+ nativeError, nativeQuicError));
+ } else {
+ failWithException(new CronetException(
+ "Exception in BidirectionalStream: " + errorString, errorCode, nativeError));
+ }
}
/**

Powered by Google App Engine
This is Rietveld 408576698