Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Issue 2137003002: [turbofan] Always run type propagation in SimplifiedLowering. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Always run type propagation in SimplifiedLowering. This unifies phases in SimplifiedLowering, and will enable more optimizations, i.e. we can do the output representation during typing then, which in turn should allow us to use the feedback type even in unchecked operators (i.e. NumberAbs). R=jarin@chromium.org Committed: https://crrev.com/897b6f789d0528d0092179b01bc0675c01d2146e Cr-Commit-Position: refs/heads/master@{#37639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Benedikt Meurer
Hey Jaro, Here's the baby. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-11 11:55:00 UTC) #7
Jarin
lgtm
4 years, 5 months ago (2016-07-11 12:04:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137003002/1
4 years, 5 months ago (2016-07-11 12:06:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 12:09:24 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 12:10:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/897b6f789d0528d0092179b01bc0675c01d2146e
Cr-Commit-Position: refs/heads/master@{#37639}

Powered by Google App Engine
This is Rietveld 408576698