Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 2138753002: [turbofan] CheckBounds with Unsigned32 inputs is also supported. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_SimplifiedLowering
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] CheckBounds with Unsigned32 inputs is also supported. If the first input to CheckBounds is already an Unsigned32, then we can just truncate both inputs to word32 and lower the bounds check. R=jarin@chromium.org Committed: https://crrev.com/41b882573e4f74beec3fc364defee029a473f866 Cr-Commit-Position: refs/heads/master@{#37643}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/compiler/simplified-lowering.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-11 12:19:10 UTC) #1
Benedikt Meurer
Hey Jaro, Another low hanging fruit (not yet practically relevant until we can use the ...
4 years, 5 months ago (2016-07-11 12:21:40 UTC) #4
Jarin
lgtm https://codereview.chromium.org/2138753002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2138753002/diff/1/src/compiler/simplified-lowering.cc#newcode1813 src/compiler/simplified-lowering.cc:1813: if (BothInputsAreUnsigned32(node)) { Is not it sufficient to ...
4 years, 5 months ago (2016-07-11 12:31:58 UTC) #5
Benedikt Meurer
https://codereview.chromium.org/2138753002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2138753002/diff/1/src/compiler/simplified-lowering.cc#newcode1813 src/compiler/simplified-lowering.cc:1813: if (BothInputsAreUnsigned32(node)) { Done, thanks.
4 years, 5 months ago (2016-07-11 12:52:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138753002/20001
4 years, 5 months ago (2016-07-11 12:52:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 13:14:16 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 13:16:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41b882573e4f74beec3fc364defee029a473f866
Cr-Commit-Position: refs/heads/master@{#37643}

Powered by Google App Engine
This is Rietveld 408576698