components/arc/ime/arc_ime_service.cc - Issue 2136933002: Add ime.ExtendSelectionAndDelete Mojo RPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/ime/arc_ime_service.cc

Issue 2136933002: Add ime.ExtendSelectionAndDelete Mojo RPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ime.ExtendSelectionAndDelete Mojo RPC Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/ime/arc_ime_service.cc

diff --git a/components/arc/ime/arc_ime_service.cc b/components/arc/ime/arc_ime_service.cc

index b8339985d6e51a2826580311256944828c5786de..560dbcea266ecd4ca94b52266f5a22407458cb6f 100644

--- a/components/arc/ime/arc_ime_service.cc

+++ b/components/arc/ime/arc_ime_service.cc

@@ -289,6 +289,10 @@ base::i18n::TextDirection ArcImeService::GetTextDirection() const {

return base::i18n::UNKNOWN_DIRECTION;

}

+void ArcImeService::ExtendSelectionAndDelete(uint32_t before, uint32_t after) {

hidehiko 2016/07/11 08:09:39 size_t != uint32_t?

takaoka 2016/07/11 08:34:55 Using uint64 for Mojo.

+ ime_bridge_->SendExtendSelectionAndDelete(before, after);

int ArcImeService::GetTextInputFlags() const {

return ui::TEXT_INPUT_FLAG_NONE;

}